Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for using transifex client tool #10434

Merged
merged 3 commits into from Jun 15, 2023

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Jun 13, 2023

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much needed!! Awesome work 🤩

I don't know if you've seen, but it seems that the Sphinx documentation also hasn't been updated.

https://www.sphinx-doc.org/en/master/usage/advanced/intl.html#using-transifex-service-for-team-translation

I have a couple of questions, but I think we should fast-forward this so adjustments can come in from active usage.

Have you tested that the steps work out in practice?

docs/user/guides/manage-translations-sphinx.rst Outdated Show resolved Hide resolved
rffontenelle and others added 2 commits June 14, 2023 11:05
Co-authored-by: Benjamin Balder Bach <benjaoming@gmail.com>
@rffontenelle
Copy link
Contributor Author

This is much needed!! Awesome work star_struck

You're welcome, I'm glad to be able to help!

I don't know if you've seen, but it seems that the Sphinx documentation also hasn't been updated.

https://www.sphinx-doc.org/en/master/usage/advanced/intl.html#using-transifex-service-for-team-translation

As I mentioned in a sub-thread here, thanks for pointing out that Sphinx documentation needs attention. I'll fix it later as well.

I have a couple of questions, but I think we should fast-forward this so adjustments can come in from active usage.

Fire away. Maybe a doubt you have can be an improvement to this documentation.

Have you tested that the steps work out in practice?

I use similar workflow to update the source strings of Python documentation's translation projects in Transifex (see GitHub Action workflow file). I don't use sphinx-intl update to build POT files because of particularities, but I've tested this part locally.

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a super welcome change. Great work @rffontenelle 👏

Read the Docs also uses Transifex, so I can guarantee someone will benefit from this update 💯

CC: @agjohnson

@benjaoming benjaoming merged commit fc9fe86 into readthedocs:main Jun 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transifex-client in docs (deprecated tool, sunset on Nov 30, 2022)
2 participants