Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxito: easy migration to custom path prefixes #10448

Merged
merged 3 commits into from Jun 20, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 19, 2023

With this we would be able to start generating
links using the path-prefix while serving docs with the old proxito implementation.

And this also allows us to start using the new implementation with just enabling the feature flag for a project. This is, without having to unset the urlconf attribute. This help us to have zero downtime while migrating projects.

With this we would be able to start generating
links using the path-prefix while serving docs with the old
proxito implementation.

And this also allows us to start using the new implementation
with just enabling the feature flag for a project.
This is, without having to unset the `urlconf` attribute.
This help us to have zero downtime while migrating projects.
@stsewd stsewd requested a review from a team as a code owner June 19, 2023 23:21
@stsewd stsewd requested a review from benjaoming June 19, 2023 23:21
@stsewd stsewd requested a review from ericholscher June 19, 2023 23:22
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I can see that there are already plenty of tests for custom_prefix and all this code enjoys coverage 👍

readthedocs/core/resolver.py Show resolved Hide resolved
@stsewd stsewd merged commit aa0ed88 into main Jun 20, 2023
4 of 5 checks passed
@stsewd stsewd deleted the easy-migration-to-path-prefixes branch June 20, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants