Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: Add tzdata as explicit requirement #10480

Merged
merged 2 commits into from Jun 28, 2023
Merged

Conversation

benjaoming
Copy link
Contributor

Requirements updated with the new inv requirements.update -p tzdata

Fixes #10453

Note to @stsewd - the invoke command generated what I assume are expected results. But it contained an error at the end. We might also wanna print the text "Warning, this command takes some minutes to finish" :)

# The following packages are considered to be unsafe in a requirements file:
# setuptools
    WARNING: Did not find branch or tag 'b696c37', assuming revision or ref.
    error: subprocess-exited-with-error
    
    × python setup.py egg_info did not run successfully.
    │ exit code: 1
    ╰─> [25 lines of output]
        /home/user/.virtualenvs/readthedocs.org/lib/python3.10/site-packages/setuptools/config/setupcfg.py:516: SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.
          warnings.warn(msg, warning_class)
        running egg_info
        creating /tmp/pip-pip-egg-info-umem36pm/psycopg2.egg-info
        writing /tmp/pip-pip-egg-info-umem36pm/psycopg2.egg-info/PKG-INFO
        writing dependency_links to /tmp/pip-pip-egg-info-umem36pm/psycopg2.egg-info/dependency_links.txt
        writing top-level names to /tmp/pip-pip-egg-info-umem36pm/psycopg2.egg-info/top_level.txt
        writing manifest file '/tmp/pip-pip-egg-info-umem36pm/psycopg2.egg-info/SOURCES.txt'
        
        Error: pg_config executable not found.
        
        pg_config is required to build psycopg2 from source.  Please add the directory
        containing pg_config to the $PATH or specify the full executable path with the
        option:
        
            python setup.py build_ext --pg-config /path/to/pg_config build ...
        
        or with the pg_config option in 'setup.cfg'.
        
        If you prefer to avoid building psycopg2 from source, please install the PyPI
        'psycopg2-binary' package instead.
        
        For further information please check the 'doc/src/install.rst' file (also at
        <https://www.psycopg.org/docs/install.html>).
        
        [end of output]
    
    note: This error originates from a subprocess, and is likely not a problem with pip.

@benjaoming benjaoming added Bug A bug dependencies Pull requests that update a dependency file labels Jun 27, 2023
@benjaoming benjaoming requested a review from a team as a code owner June 27, 2023 11:48
@benjaoming benjaoming requested a review from stsewd June 27, 2023 11:48
@humitos
Copy link
Member

humitos commented Jun 27, 2023

Should this issue be fixed automatically by upgrading Celery as Santos mentioned in the other issue?

@benjaoming
Copy link
Contributor Author

I wrote a response to that comment before opening this PR: #10453 (comment)

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

requirements/pip.in Show resolved Hide resolved
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@stsewd
Copy link
Member

stsewd commented Jun 27, 2023

Note to @stsewd - the invoke command generated what I assume are expected results. But it contained an error at the end. We might also wanna print the text "Warning, this command takes some minutes to finish" :)

that error is because you are missing installing some system dependencies for psycopg2, see

run: sudo apt-get install libpq-dev
. Alternative, you can run the command from inside the docker container.

@benjaoming
Copy link
Contributor Author

Ah, gotcha, I wasn't expecting that outcome from running pip-tools to update packages. But makes sense 👍

@benjaoming benjaoming merged commit e38d135 into main Jun 28, 2023
7 checks passed
@benjaoming benjaoming deleted the bug/tzdata-missing branch June 28, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery: ZoneInfoNotFoundError on development instance
3 participants