Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct typo #10489

Merged
merged 1 commit into from Jun 28, 2023
Merged

docs: Correct typo #10489

merged 1 commit into from Jun 28, 2023

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Jun 28, 2023

The example uses the 'pip' install method but the explanation suggests it should have used 'pip'.


馃摎 Documentation previews 馃摎

The example uses the 'pip' install method but the explanation suggests
it should have used 'pip'.

Signed-off-by: Stephen Finucane <stephen@that.guru>
@stephenfin stephenfin requested a review from a team as a code owner June 28, 2023 09:08
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挴

thanks for spotting this and fixing it 馃憤

@benjaoming benjaoming merged commit cdee91d into readthedocs:main Jun 28, 2023
8 checks passed
@humitos
Copy link
Member

humitos commented Jun 28, 2023

I don't think this is correct. IIRC, setuptools is deprecated and we don't want people to use it. pip is the correct option here cc @stsewd

@benjaoming
Copy link
Contributor

@humitos I know, but read the whole context. Fixing a typo made the text correct and meaningful.

Removing setuptools from the example requires bigger changes.

humitos added a commit that referenced this pull request Jun 28, 2023
humitos added a commit that referenced this pull request Jun 28, 2023
@stephenfin stephenfin deleted the docs/use-setuptools-in-example branch June 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants