Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: define html_theme variable #10663

Merged
merged 2 commits into from Aug 24, 2023
Merged

Build: define html_theme variable #10663

merged 2 commits into from Aug 24, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 24, 2023

Use the global value or alabaster if not defined by the user. It default to alabaster because it's the default value for Sphinx.

Closes #10662
Related #10638

Use the global value or `alabaster` if not defined by the user.
It default to `alabaster` because it's the default value for Sphinx.
@humitos humitos requested a review from a team as a code owner August 24, 2023 14:38
@humitos humitos requested a review from stsewd August 24, 2023 14:38
@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

Fails in current production: https://readthedocs.org/projects/test-builds/builds/21709247/ and pass locally 🎉

@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

We can talk about deploying a hotfix for this if we consider.

@humitos humitos merged commit f999d65 into main Aug 24, 2023
7 checks passed
@humitos humitos deleted the humitos/build-html-theme branch August 24, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds failing with html_theme not set
2 participants