Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black pass number 2 #10693

Merged
merged 3 commits into from Aug 31, 2023
Merged

Black pass number 2 #10693

merged 3 commits into from Aug 31, 2023

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Aug 30, 2023

Same method as last time. It seems darker and black do not always agree for some
reason though, not sure why.

Output:

reformatted readthedocs/api/v3/permissions.py
reformatted readthedocs/api/v3/tests/test_builds.py
reformatted readthedocs/api/v2/serializers.py
reformatted readthedocs/builds/tests/test_build_queryset.py
reformatted readthedocs/builds/tasks.py
reformatted readthedocs/core/resolver.py
reformatted readthedocs/core/utils/filesystem.py
reformatted readthedocs/doc_builder/exceptions.py
reformatted readthedocs/integrations/migrations/0007_update-provider-data.py
reformatted readthedocs/doc_builder/environments.py
reformatted readthedocs/organizations/tests/test_views.py
reformatted readthedocs/projects/tasks/mixins.py
reformatted readthedocs/projects/views/mixins.py
reformatted readthedocs/proxito/tests/test_middleware.py
reformatted readthedocs/redirects/querysets.py
reformatted readthedocs/proxito/views/mixins.py
reformatted readthedocs/rtd_tests/files/conf.py
reformatted readthedocs/proxito/tests/test_custom_path_prefixes.py
reformatted readthedocs/proxito/tests/test_redirects.py
reformatted readthedocs/rtd_tests/tests/test_build_config.py
reformatted readthedocs/rtd_tests/tests/test_backend.py
reformatted readthedocs/rtd_tests/tests/test_core_utils.py
reformatted readthedocs/rtd_tests/tests/test_middleware.py
reformatted readthedocs/rtd_tests/tests/test_footer.py
reformatted readthedocs/rtd_tests/tests/test_project_views.py
reformatted readthedocs/rtd_tests/tests/test_project_forms.py
reformatted readthedocs/rtd_tests/utils.py
reformatted readthedocs/rtd_tests/tests/test_resolver.py
reformatted readthedocs/rtd_tests/tests/test_sync_versions.py
reformatted readthedocs/subscriptions/forms.py
reformatted readthedocs/vcs_support/backends/__init__.py
reformatted readthedocs/vcs_support/backends/bzr.py
reformatted readthedocs/vcs_support/backends/hg.py
reformatted readthedocs/vcs_support/base.py
reformatted readthedocs/vcs_support/backends/svn.py

All done! ✨ 🍰 ✨
35 files reformatted, 677 files left unchanged.

Getting very close too, another pass of the whole directory after this shows:

...
64 files reformatted, 729 files left unchanged.

@agjohnson agjohnson requested a review from a team as a code owner August 30, 2023 19:58
@agjohnson agjohnson requested a review from stsewd August 30, 2023 19:58
@agjohnson agjohnson requested a review from humitos August 30, 2023 19:59
@agjohnson
Copy link
Contributor Author

agjohnson commented Aug 30, 2023

@humitos I'm confused by darker and black fighting over line changes. Did you hit this on the first pass?

Edit: nevermind, I just let darker win out that fight. We can do a final pass when we drop it.

@humitos
Copy link
Member

humitos commented Aug 31, 2023

Merging to avoid conflicts πŸ˜„

@humitos humitos merged commit b1b9704 into main Aug 31, 2023
7 checks passed
@humitos humitos deleted the agj/black-08-30 branch August 31, 2023 10:25
@sentry-io
Copy link

sentry-io bot commented Sep 6, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: sequence item 0: expected str instance, NoneType found readthedocs.projects.tasks.builds.update_docs_task View Issue

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants