Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: use tag name for checkout #10879

Merged
merged 2 commits into from Oct 31, 2023
Merged

Build: use tag name for checkout #10879

merged 2 commits into from Oct 31, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 31, 2023

Instead of relying on the commit, we can just use the name of the tag, this solves the problem where we are using an old commit when a tag is force pushed.

Fixes #10838

@stsewd stsewd requested a review from a team as a code owner October 31, 2023 01:42
@stsewd stsewd requested a review from humitos October 31, 2023 01:42
humitos
humitos approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like to double check the logic we have in two different places to be sure that it keeps making sense. Also, it would be good to write down a comment on the changed line explaining why this one is the correct identifier.

readthedocs/doc_builder/director.py Show resolved Hide resolved
@stsewd stsewd merged commit 42a82ca into main Oct 31, 2023
7 checks passed
@stsewd stsewd deleted the use-version-name-for-checkout branch October 31, 2023 15:37
stsewd added a commit that referenced this pull request Nov 2, 2023
@stsewd
Revert "Build: use tag name for checkout (#10879)"
0cfa2d6 
This reverts commit 42a82ca.
@stsewd stsewd mentioned this pull request Nov 2, 2023
Merged
stsewd added a commit that referenced this pull request Nov 2, 2023
@stsewd
Revert "Build: use tag name for checkout (#10879)"
5334e5a 
This reverts commit 42a82ca.
stsewd added a commit that referenced this pull request Nov 2, 2023
@stsewd
Revert "Build: use tag name for checkout (#10879)"
750fbf2 
This reverts commit 42a82ca.
stsewd added a commit that referenced this pull request Nov 2, 2023
@stsewd
Revert "Build: use tag name for checkout" (#10887)
df99aec 
Revert "Build: use tag name for checkout (#10879)"

This reverts commit 42a82ca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version in ReadTheDocs retains the tags commit ID preventing a rebuild based on the updated commit for the TAG
2 participants
@stsewd @humitos