Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structlog by downgrading it #11003

Merged
merged 2 commits into from Jan 8, 2024
Merged

Fix structlog by downgrading it #11003

merged 2 commits into from Jan 8, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 5, 2024

Refs #10990

@ericholscher ericholscher requested a review from a team as a code owner January 5, 2024 23:07
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Jan 5, 2024
@humitos humitos merged commit bf2879c into main Jan 8, 2024
5 of 6 checks passed
@humitos humitos deleted the pin-structlog branch January 8, 2024 10:57
humitos added a commit that referenced this pull request Jan 8, 2024
In #11003 we downgrade structlog, but we didn't update all the requirement files.
@humitos humitos mentioned this pull request Jan 8, 2024
@humitos
Copy link
Member

humitos commented Jan 8, 2024

When changing a dependency, make sure you are running pip-compile over all the files. Otherwise, there are some incompatibilities between them.

I usually run,

pip-compile -U requirements/pip.in
for file in requirements/*.in; do pip-compile --output-file=`echo $file | cut -f 1 -d .`.txt $file; done

To make sure that all the files are properly updated.

See #11010

humitos added a commit that referenced this pull request Jan 8, 2024
In #11003 we downgrade structlog, but we didn't update all the requirement files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants