Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the index page to match the sidebar #11141

Merged
merged 1 commit into from Feb 23, 2024
Merged

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 23, 2024

This is basically just pulling the main bits from the sidebar,
and putting them in the front page.

@ericholscher ericholscher requested a review from a team as a code owner February 23, 2024 14:14
@ericholscher ericholscher changed the base branch from main to docs-nav-refactor February 23, 2024 14:18
Base automatically changed from docs-nav-refactor to main February 23, 2024 14:32
@ericholscher ericholscher changed the title index refactor Refactor the index page to match the sidebar Feb 23, 2024
This is basically just pulling the main bits from the sidebar,
and putting them in the front page.
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks great, it's much better.

Re emojis: I like including some, but I prefer how this doesn't use emojis as bullet points. It looks better without them to me.

I think graphic elements -- images of our UIs or even just supporting images -- do a better job of bringing life to the docs.

@ericholscher ericholscher merged commit 7881096 into main Feb 23, 2024
7 checks passed
@ericholscher ericholscher deleted the index-refactor branch February 23, 2024 20:48
@ericholscher
Copy link
Member Author

ericholscher commented Feb 23, 2024

Yea, I mostly just got annoyed at having to figure out emojis and killed them to make it easier to move forward. I think we could play around with them sparingly.

There's definitely additional work here to do, but this is a reasonable first step.

@humitos
Copy link
Member

humitos commented Feb 24, 2024

I like the idea of using emojis/icons. Here is an example where I think they work great: https://about.readthedocs.com/comparisons/github-pages/ --where it uses an emoji/icon kind of related to the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants