Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: show the YAML config file before validating it #11175

Merged
merged 4 commits into from Mar 4, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 29, 2024

This moves the cat readthedocs.yaml command before validating the YAML file.
This allows the user to inspect the configuration file in case it fails due to a
validation error.

Screenshot_2024-02-29_19-14-43

Closes #11097

This moves the `cat readthedocs.yaml` command _before_ validating the YAML file.
This allows the user to inspect the configuration file in case it fails due to a
validation error.

Closes #11097
@humitos humitos requested a review from a team as a code owner February 29, 2024 18:05
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough.

We can't perform this check on the "build environment" because it happens in the
"VCS environment" now and we are not mocking it.

We should find a way to check these commands on the "VCS environment".
@humitos humitos enabled auto-merge (squash) March 4, 2024 10:09
@humitos humitos merged commit a49f111 into main Mar 4, 2024
4 checks passed
@humitos humitos deleted the humitos/show-yaml-before-validating branch March 4, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: run cat readthedocs.yaml even when there is a config error
2 participants