Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init path to ensure it exists #11178

Merged
merged 1 commit into from Mar 4, 2024
Merged

Init path to ensure it exists #11178

merged 1 commit into from Mar 4, 2024

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested a review from a team as a code owner March 1, 2024 21:55
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Mar 2, 2024
humitos
humitos approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a hotfix.

We should log something if the path == "" when returning because that means the notification is not attached to known object --which is wrong. Can you add this log line in the PR? 🙏🏼

@humitos
Copy link
Member

humitos commented Mar 4, 2024

Also, can you link the Sentry issue here so we can take a look?

@ericholscher
Copy link
Member Author

ericholscher commented Mar 4, 2024 •
edited

https://read-the-docs.sentry.io/issues/5019545729/

@ericholscher ericholscher merged commit 375a408 into main Mar 4, 2024
7 checks passed
@ericholscher ericholscher deleted the fix-path branch March 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@ericholscher ericholscher

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericholscher @humitos