Support: create a form to render it nicely in ext-theme #11193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Django form and crispy filter to render the form on the support page. Also moves the logic from the template to the form itself.
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Mar 6, 2024
It seems that crispy forms semanticui uses a file that doesn't define. I'm following the pattern we have here to "override" this file in our own repository. This is required for readthedocs/readthedocs.org#11193
agjohnson
approved these changes
Mar 6, 2024
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Mar 6, 2024
We want to keep track of this file in the new ext-theme. See readthedocs/readthedocs.org#11193 (comment)
We moved the template over there.
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Mar 6, 2024
It seems that crispy forms semanticui uses a file that doesn't define. I'm following the pattern we have here to "override" this file in our own repository. This is required for readthedocs/readthedocs.org#11193
agjohnson
approved these changes
Mar 6, 2024
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Mar 6, 2024
We want to keep track of this file in the new ext-theme. See readthedocs/readthedocs.org#11193 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a Django form and crispy filter to render the form on the support page. Also moves the logic from the template to the form itself.
Demo
Closes readthedocs/ext-theme#296