Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: basic docs for SAML SSO #11288

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Docs: basic docs for SAML SSO #11288

wants to merge 4 commits into from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 17, 2024

We still need to figure out a couple of things, but I think it doesn't hurt to have some basic docs about this feature.

This follows the same structure from other guides related to SSO, preview at https://docs--11288.org.readthedocs.build/en/11288/guides/set-up-single-sign-on-saml.html.

Ref #11262


馃摎 Documentation previews 馃摎

stsewd and others added 4 commits April 17, 2024 13:12
We still need to figure out a couple of things, but I think it doesn't
hurt to have some basic docs about this feature.

Ref #11262
@stsewd stsewd marked this pull request as ready for review May 1, 2024 18:51
@stsewd stsewd requested a review from a team as a code owner May 1, 2024 18:51
@stsewd stsewd requested a review from agjohnson May 1, 2024 18:51
@stsewd
Copy link
Member Author

stsewd commented May 1, 2024

This documentation isn't complete, as the SAML feature isn't complete yet, but should be good enough to guide users that want to beta test it or for ourselves.

@cklim5

This comment was marked as spam.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good as a first step to me 馃憤馃徏

User setup
~~~~~~~~~~

Using this setup, all users who have access to the configured Okta application will automatically join to your organization when they sign up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using this setup, all users who have access to the configured Okta application will automatically join to your organization when they sign up.
Using this setup, all users who have access to the configured Okta application will automatically join to your Read the Docs organization when they sign up.

Comment on lines +71 to +72
By default, users that sign up with SAML do not have any permissions over any project.
However, you can define which teams users will auto-join when they sign up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we creating a team automatically when SAML is enabled on an organization in a similar way as we are doing with Google SSO? If not, we should probably do the same and enable auto-join on that team. I think it's a good idea to keep consistency between these two SSO providers.

Comment on lines +79 to +80
Existing users with email addresses from your configured domain will not be required to sign up using SAML,
but they won't be automatically joined to your organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to enforce this in the next login after enabling SAML for the organization?

Configure team for all users to join
------------------------------------

You can mark one or many teams that users are automatically joined when they sign up with a matching email address.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can mark one or many teams that users are automatically joined when they sign up with a matching email address.
You can mark one or more teams that users will be automatically joined when they sign up with a matching email address.

they may still have access to documentation pages until their session expires.
This is three days for the dashboard and documentation pages.

To completely revoke access to a user, remove them from all the teams they are part of.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we talked about this a few times, but I'm not sure if we have an issue to track this. I think it's important to find a way of logout the users if they are revoked access. Do we have an issue for this that we can prioritize its research?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants