Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take preferece of tags over branches when selecting the stable version #3331

Merged
merged 9 commits into from Nov 29, 2017
Merged

Take preferece of tags over branches when selecting the stable version #3331

merged 9 commits into from Nov 29, 2017

Commits on Nov 29, 2017

  1. Fix isort settings

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    4a14c56 View commit details
    Browse the repository at this point in the history

  2. Improve docstrings and style

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    5adbdd1 View commit details
    Browse the repository at this point in the history

  3. Style rules applied to test_sync_versions

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    f9c567e View commit details
    Browse the repository at this point in the history

  4. Add pdbpp for local debugging

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    682a7fa View commit details
    Browse the repository at this point in the history

  5. Take preference of tags over branches to get stable version

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    fd0b406 View commit details
    Browse the repository at this point in the history

  6. Do not update version type when sync versions 

    This allows us to have the same `verbose_name` for different type of
versions (for example, '2.0' could both a tag and a branch). If this
happen, we want to keep them both.

In the UI, it will say just `"2.0"` for the branch and
`"2.0 (c0d25453)"` for the tag. This could be improved later if
necessary.
    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    073b0c0 View commit details
    Browse the repository at this point in the history

  7. Test for tags over branches versions

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    1d76453 View commit details
    Browse the repository at this point in the history

  8. 'most up to date version' note prefers tags 

    Now, this logic is like this:

- if the project has any Version that is a TAG, the highest version
  will only be a TAG also (BRANCH are not considered)
- if the project doesn't have any TAG the highest version will be a
  BRANCH (or UNKNOWN in the worst case)
    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    bcfbca8 View commit details
    Browse the repository at this point in the history

  9. More styling

    @humitos
    humitos committed Nov 29, 2017
    Copy the full SHA
    20ce7aa View commit details
    Browse the repository at this point in the history