Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search bar in dashboard have a more clear message. #3844

Merged
merged 2 commits into from May 24, 2018
Merged

Make search bar in dashboard have a more clear message. #3844

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589d077
Make search bar in dashboard have a more clear message.
ze Mar 24, 2018
3d96a06
Make string translatable
ze Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/templates/projects/project_dashboard_base.html
View file
Open in desktop
Expand Up @@ -115,7 +115,7 @@ <h3>{% trans "Projects" %}</h3>
<div class="module search search-dashboard">
<form action="{% url 'search' %}" method="GET">
<div class="text-input-wrapper search search-dashboard">
<input type="text" name="q" class="search">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the string translatable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, it's been done!

<input type="text" name="q" class="search" placeholder="Search Read the Docs">
{% if type %}
<input type="hidden" name="type" value="{{ type }}">
{% endif %}
Expand Down