Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Docker image hash in RTD environment.json file #3880

Merged
merged 4 commits into from Mar 31, 2018

Commits on Mar 29, 2018

  1. Save docker image hash to consider when auto wiping the environment (#…

    …3793)
    
    * Remove obsolete code
    
    Now, we can access `self.config.build_image` directly.
    
    * Move container_image selection to the init
    
    At initialization time we have the project and we already know if the
    project has the build image override so we can decide at that point
    and save it as a instance attribute.
    
    Then we can use this values from other places inside the same class.
    
    * Save Docker Image hash in readthedocs-environment.json
    
    The hash is used to know if the environment is obsolete and auto-wipe
    it if necessary.
    
    * Simplify the class naming
    
    * Save the image hash in the json file
    
    * Lint
    
    * Remove invalid properties from YAML config in tests
    
    * Add test for save_environment_json
    humitos committed Mar 29, 2018
    Copy the full SHA
    3fb3c3d View commit details
    Browse the repository at this point in the history
  2. Improve docstring

    humitos committed Mar 29, 2018
    Copy the full SHA
    a97b3d0 View commit details
    Browse the repository at this point in the history
  3. Handle obsolete cases better

    * when the file is corrupted or we don't have access, we return that
      it's OBSOLETE
    
    * when there is a new setting that we need to compare and it's not in
      the JSON file, we return OBSOLETE
    humitos committed Mar 29, 2018
    Copy the full SHA
    7ddf1fb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2018

  1. Copy the full SHA
    28b8ae1 View commit details
    Browse the repository at this point in the history