Don't share state in build task #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move task steps to an isolated class, instead of possibly sharing state in between tasks. This bug is not consistently reproduceable, but one consistent way to reproduce is to drop to ``rdb`` on the UpdateDocsTask run method. Previously, if you did this while running 2 celery processes, and triggered 2 builds, you could witness state changing on the task instance. By moving state to a separate class that is instantiated on each task execution, this completely avoids shared state in these tasks.
ericholscher
approved these changes
Apr 14, 2018
|
I do think we should have docstrings here explaining the design though. Otherwise I could see this getting refactored away as unneeded complexity. |
humitos
approved these changes
Apr 14, 2018
|
I want to add some context here that I found while reading how to use the celery framework instead a custom workaround to fix this: Those two links, talks about similar issues. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move task steps to an isolated class, instead of possibly sharing state in
between tasks. This bug is not consistently reproduceable, but one consistent
way to reproduce is to drop to
rdbon the UpdateDocsTask run method.Previously, if you did this while running 2 celery processes, and triggered 2
builds, you could witness state changing on the task instance. By moving state
to a separate class that is instantiated on each task execution, this completely
avoids shared state in these tasks.