Return 404 for inactive versions and allow redirects on them #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a version exists and is inactive, we return 404 instead of 401 so our redirect system can be used for these versions. We only return 401 when the reader has no permission to read the version (active and private).
stsewd
approved these changes
Sep 4, 2018
agjohnson
pushed a commit
that referenced
this pull request
Sep 6, 2018
Return 404 for inactive versions and allow redirects on them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a version exists and is inactive, we return 404 instead of 401 so our redirect system can be used for these versions.
We only return 401 when the reader has no permission to read the version (active and private).
Closes #4598