Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 for inactive versions and allow redirects on them #4599

Merged
merged 1 commit into from Sep 5, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Sep 4, 2018

When a version exists and is inactive, we return 404 instead of 401 so our redirect system can be used for these versions.

We only return 401 when the reader has no permission to read the version (active and private).

Closes #4598

When a version exists and is inactive, we return 404 instead of 401 so
our redirect system can be used for these versions.

We only return 401 when the reader has no permission to read the
version (active and private).
@humitos humitos requested a review from Sep 4, 2018
stsewd
stsewd approved these changes Sep 4, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@humitos humitos merged commit 45b6ead into master Sep 5, 2018
1 check passed
@humitos humitos deleted the humitos/serve/inactive-version branch Sep 5, 2018
agjohnson added a commit that referenced this issue Sep 6, 2018
Return 404 for inactive versions and allow redirects on them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants