Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sudo from travis #4919

Merged
merged 1 commit into from Dec 3, 2018
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 20, 2018

It will be removed soon
https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

@codecov
Copy link

@codecov codecov bot commented Nov 20, 2018

Codecov Report

Merging #4919 into master will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4919      +/-   ##
==========================================
- Coverage   76.75%   75.61%   -1.14%     
==========================================
  Files         158      158              
  Lines       10048    10048              
  Branches     1265     1265              
==========================================
- Hits         7712     7598     -114     
- Misses       1995     2132     +137     
+ Partials      341      318      -23
Impacted Files Coverage Δ
readthedocs/search/views.py 30.23% <0%> (-44.19%) ⬇️
readthedocs/search/lib.py 18.03% <0%> (-37.71%) ⬇️
readthedocs/search/indexes.py 40.98% <0%> (-36.07%) ⬇️
readthedocs/restapi/utils.py 74.77% <0%> (-16.22%) ⬇️
readthedocs/core/templatetags/core_tags.py 60.65% <0%> (-8.2%) ⬇️
readthedocs/projects/tasks.py 70.2% <0%> (-1%) ⬇️

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 20, 2018

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 20, 2018

I'm not sure why ES isn't working on xenial :/

@safwanrahman any ideas here? Maybe we can follow this steps now? https://docs.travis-ci.com/user/database-setup/#installing-specific-versions-of-elasticsearch

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Nov 20, 2018

@stsewd I am hoping to get the ES6 merged, so we can rebase and check if the new version is also failing.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 20, 2018

Got it, we have till december 7th, if not, I can revert the xenial update and just remove sudo: false in this PR.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 21, 2018

I think I know where the problem is, we need java7

curl: (7) Failed to connect to 127.0.0.1 port 9200: Connection refused
Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
Unrecognized VM option 'UseParNewGC'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit

@stsewd
Copy link
Member Author

@stsewd stsewd commented Nov 26, 2018

I was unable to install java7 on travis to make ES work :/, I'm just back to removing sudo here, hope we can get the new ES update merged soon.

@stsewd stsewd requested a review from Nov 26, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good. 👍

@humitos
Copy link
Member

@humitos humitos commented Dec 3, 2018

Is there anything missing here or we can merge it as is?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 3, 2018

Nope, we can merge this

@stsewd stsewd merged commit 46b5e06 into readthedocs:master Dec 3, 2018
3 checks passed
@stsewd stsewd deleted the update-travis branch Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants