Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak some ad styles #5237

Merged
merged 1 commit into from Feb 5, 2019
Merged

Tweak some ad styles #5237

merged 1 commit into from Feb 5, 2019

Conversation

davidfischer
Copy link
Contributor

  • Add the ability to have badges to highlight a tech stack
  • Remove underlines on links

Screenshots

screen shot 2019-02-05 at 11 29 19 am

screen shot 2019-02-05 at 11 30 20 am

@davidfischer
Tweak some ad styles
f220ca1 
- Add the ability to have badges to highlight a tech stack
- Remove underlines on links
@davidfischer davidfischer requested a review from a team February 5, 2019 19:30
ericholscher
ericholscher approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a strong grasp of the CSS, but the screenshots look good :)

@davidfischer davidfischer merged commit 080d6cf into master Feb 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/ad-style-tweaks branch February 5, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidfischer @ericholscher