Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchAnalytics view #6190

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@stsewd
Copy link
Member

commented Sep 17, 2019

ref #5856

ref #5856
@stsewd

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

It was missing testing locally, now it's done :D

@stsewd stsewd requested a review from readthedocs/core Sep 18, 2019
@humitos
humitos approved these changes Oct 2, 2019
project=project,
created__date__gte=last_3_month,
created__date__lte=now,
def _search_analytics_csv_data(self):

This comment has been minimized.

Copy link
@humitos

humitos Oct 2, 2019

Member

I think this could be better as a helper/util function returning the data instead a of a class method and be called from the class that constructs the response.

Not really relevant at this point since it's not called from another place, though.

@stsewd stsewd merged commit 8e643fb into readthedocs:master Oct 2, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd stsewd deleted the stsewd:refactor-views-search-analytics branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.