Refactor SearchAnalytics view #6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was missing testing locally, now it's done :D |
stsewd
removed
the
PR: work in progress
humitos
approved these changes
Oct 2, 2019
| project=project, | ||
| created__date__gte=last_3_month, | ||
| created__date__lte=now, | ||
| def _search_analytics_csv_data(self): |
There was a problem hiding this comment.
I think this could be better as a helper/util function returning the data instead a of a class method and be called from the class that constructs the response.
Not really relevant at this point since it's not called from another place, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5856