Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchAnalytics view #6190

merged 3 commits into from Oct 2, 2019


Copy link

@stsewd stsewd commented Sep 17, 2019

ref #5856

Copy link
Member Author

@stsewd stsewd commented Sep 18, 2019

It was missing testing locally, now it's done :D

@stsewd stsewd requested a review from Sep 18, 2019
humitos approved these changes Oct 2, 2019
def _search_analytics_csv_data(self):
Copy link

@humitos humitos Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be better as a helper/util function returning the data instead a of a class method and be called from the class that constructs the response.

Not really relevant at this point since it's not called from another place, though.

@stsewd stsewd merged commit 8e643fb into readthedocs:master Oct 2, 2019
2 checks passed
@stsewd stsewd deleted the refactor-views-search-analytics branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants