Upgrade to Django 2.2.9 #6494
The on_delete argument for ForeignKey and OneToOneField is now required in models and migrations. Consider squashing migrations so that you have fewer of them to update. https://docs.djangoproject.com/en/3.0/releases/2.0/#backwards-incompatible-changes-in-2-0
These permissions are created automatically by Django 2.x: https://docs.djangoproject.com/en/2.2/ref/models/options/#default-permissions The `view_` permission was added in 2.1. We were creating it manually when using 1.11.
To catch usage mistakes, the test Client and django.utils.http.urlencode() now raise TypeError if None is passed as a value to encode because None can’t be encoded in GET and POST data. Either pass an empty string or omit the value.
My main concern is about running the migrations (since they are modified) on a prod-like database. It should not be a problem because we are making the default value explicit only. However, that would be a good test.
Another thing to verify is that creating an environment from scratch (without any migration ran yet) it does work.
Locally, I did some QA and I didn't find anything strange/wrong.
On the other hand, I'm blocking this PR since we need to make the merge of other dependencies (-ext and corporate) together with this one. Aside from that, we can test this PR without problems in .org.
I hadn't considered this. That's pretty unfortunate, but I think the way you did it is probably best.
Note: this is what the 1.9 release notes suggest as well.
We are setting this view as handler404 on tests, this view expects an extra arg (exception) https://docs.djangoproject.com/en/2.2/ref/views/#the-404-page-not-found-view (not sure why it worked before)
I have update this PR with
We are setting this view as handler404 on tests,
(not sure why it worked before)
There are some migrations from django that we need to run