Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change htmldir to dirhtml #6497

Closed
wants to merge 2 commits into from
Closed

Change htmldir to dirhtml #6497

wants to merge 2 commits into from

Conversation

Blackcipher101
Copy link
Contributor

fixes #6038

stsewd
stsewd requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We shouldn't replace the value, we just need to add the new one and make it work like the old one, otherwise this will break everyone builds

@Blackcipher101
Copy link
Contributor Author

@stsewd ok I will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml config uses "htmldir" instead of "dirhtml"
2 participants
@Blackcipher101 @stsewd