Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide: private python packages in .com #6530

Merged
merged 12 commits into from Apr 20, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 16, 2020

Still WIP, everything may change

@stsewd stsewd added the PR: work in progress label Jan 16, 2020
docs/guides/private-python-packages.rst Outdated Show resolved Hide resolved
docs/guides/private-python-packages.rst Outdated Show resolved Hide resolved
The URI should be in your :ref:`requirements file <config-file/v2:Requirements file>`.
PIP will automatically expand environment variables in your URI,
you can :doc:`add environment variables </guides/environment-variables>` in Read the Docs,
so you don't to hard code the token in the URI.
Copy link
Contributor

@davidfischer davidfischer Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check this, but could this be used to add a private dependency on readthedocs.org?

Copy link
Member Author

@stsewd stsewd Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be used to install private packages in .org, Not sure if users will use this in .org, if you have a private dependency your repo should be private too?

@stsewd stsewd force-pushed the guide-private-python-packages branch from 4f66e2d to dc3f4a1 Compare Feb 18, 2020
@stsewd stsewd removed the PR: work in progress label Feb 18, 2020
@stsewd stsewd requested a review from davidfischer Feb 18, 2020
@stsewd stsewd requested a review from Apr 15, 2020
Copy link
Member

@ericholscher ericholscher left a comment

This is useful even if it's not perfect. I'm 👍on merging it with my edits and we can make it nicer as we get feedback.

docs/guides/private-python-packages.rst Outdated Show resolved Hide resolved
docs/guides/private-python-packages.rst Outdated Show resolved Hide resolved
docs/guides/private-python-packages.rst Outdated Show resolved Hide resolved
stsewd and others added 2 commits Apr 20, 2020
Co-Authored-By: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@stsewd stsewd merged commit dd9fa04 into readthedocs:master Apr 20, 2020
2 checks passed
@stsewd stsewd deleted the guide-private-python-packages branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants