Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More protection against None #6597

Merged
merged 1 commit into from Feb 3, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 28, 2020

If the api fails, self.project and self.version are going to be None
and error when logging to sentry

If the api fails, self.project and self.version are going to be None
and error when logging to sentry
@stsewd stsewd requested a review from a team January 29, 2020 16:55
@ericholscher ericholscher merged commit 336a3ff into readthedocs:master Feb 3, 2020
@stsewd stsewd deleted the more-none-protection branch February 3, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants