Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override app from where to read templates #6821

Merged
merged 1 commit into from Mar 26, 2020
Merged

Allow to override app from where to read templates #6821

merged 1 commit into from Mar 26, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 25, 2020

This is needed to refactor .com

@stsewd stsewd requested a review from humitos March 25, 2020 20:21
humitos
humitos reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems trivial.

Although, I want to understand how/where is it used. I assume that we are reading the template from a different app that the model app, but why?

@humitos
Copy link
Member

humitos commented Mar 26, 2020

Although, I want to understand how/where is it used. I assume that we are reading the template from a different app that the model app, but why?

Haha! I made this suggestion in another PR. I just found it!

@stsewd stsewd merged commit 7de9836 into master Mar 26, 2020
@stsewd stsewd deleted the move-templates-subscription branch March 26, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @humitos