Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document HSTS support #7083

Merged
merged 1 commit into from May 18, 2020
Merged

Document HSTS support #7083

merged 1 commit into from May 18, 2020

Conversation

davidfischer
Copy link
Contributor

Fixes #7062

@davidfischer davidfischer requested a review from a team May 14, 2020 22:39
humitos
humitos reviewed May 18, 2020
View reviewed changes
docs/custom_domains.rst

By default, we do not return a `Strict Transport Security header`_ (HSTS) for user custom domains.
This is a conscious decision as it can be misconfigured in a not easily reversible way.
For both |org_brand| and |com_brand|, HSTS for custom domains can be set upon request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is worth to mention how to make that request, with the link to the email?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mention contacting support, but I think we don't need to include a link here, since it would be different for each site?

ericholscher
ericholscher approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

docs/custom_domains.rst

By default, we do not return a `Strict Transport Security header`_ (HSTS) for user custom domains.
This is a conscious decision as it can be misconfigured in a not easily reversible way.
For both |org_brand| and |com_brand|, HSTS for custom domains can be set upon request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mention contacting support, but I think we don't need to include a link here, since it would be different for each site?

@ericholscher ericholscher merged commit 8652573 into master May 18, 2020
@ericholscher ericholscher deleted the davidfischer/document-hsts-support branch May 18, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document HSTS support
3 participants
@davidfischer @ericholscher @humitos