-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyup: Scheduled weekly dependency update for week 06 #7896
Conversation
Tabs aren't working https://docs--7896.org.readthedocs.build/en/7896/config-file/v2.html maybe something to do with this change
Something incompatible somewhere? |
Can't replicate locally, and tabs in their docs work fine :/ https://sphinx-tabs.readthedocs.io/en/latest/ |
It's like the click event doesn't get attached... but running the debugger that code gets executed. After attaching them again manually they work const allTabs = document.querySelectorAll('.sphinx-tabs-tab');
allTabs.forEach(tab => {
tab.addEventListener("click", changeTabs);
}); So is like something is unregistering the events somewhere |
ae68a7b
to
ee047f7
Compare
Ok, looks like search is the incompatible one readthedocs/readthedocs-sphinx-search#82 |
requirements/docs.txt
Outdated
@@ -11,7 +11,7 @@ Sphinx==3.4.3 | |||
docutils==0.14 # pyup: ignore | |||
|
|||
sphinx_rtd_theme==0.5.1 | |||
sphinx-tabs==2.0.1 | |||
sphinx-tabs==1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a # pyup: ignore
and a comment explaining why we can't upgrade it yet linking to the issue in search extension
Update virtualenv from 20.4.1 to 20.4.2.
Changelog
20.4.2
Links
Update django-extensions from 3.1.0 to 3.1.1.
Changelog
3.1.1
Links
Update stripe from 2.55.1 to 2.55.2.
Changelog
2.55.2
Links
Update tox from 3.21.3 to 3.21.4.
Changelog
3.21.4
Links
Update sphinx-tabs from 1.3.0 to 2.0.1.
Changelog
2.0.1
2.0.0
Links