Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyup: Scheduled weekly dependency update for week 06 #7896

Merged
merged 10 commits into from
Feb 9, 2021

Conversation

pyup-bot
Copy link
Collaborator

@pyup-bot pyup-bot commented Feb 8, 2021

Update virtualenv from 20.4.1 to 20.4.2.

Changelog

20.4.2

~~~~~~~~~~~~~~~~~
- Running virtualenv ``--upgrade-embed-wheels`` crashes - by :user:`gaborbernat`. (`2058 <https://github.com/pypa/virtualenv/issues/2058>`_)
Links

Update django-extensions from 3.1.0 to 3.1.1.

Changelog

3.1.1

-----

Changes:
- Improvement: graph_models, add option --app-labels
- Improvement: shell_plus, update shell_plus for jupyterlab 3
- Improvement: tests, add Python 3.9
Links

Update stripe from 2.55.1 to 2.55.2.

Changelog

2.55.2

* [704](https://github.com/stripe/stripe-python/pull/704) Fix CA bundle path issue
Links

Update tox from 3.21.3 to 3.21.4.

Changelog

3.21.4

--------------------

Bugfixes
^^^^^^^^

- Adapt tests not to assume the ``easy_install`` command exists, as it was removed from ``setuptools`` 52.0.0+ - by :user:`hroncok`
`1893 <https://github.com/tox-dev/tox/issues/1893>`_
Links

Update sphinx-tabs from 1.3.0 to 2.0.1.

Changelog

2.0.1

Fixed

* Nested parsing of tab labels, to support use of reST roles within label text
* Parsing tabs with unsupported builders, including for pdf

Added

* Test for successful pdf building using `rinohtype`

2.0.0

♻️ Refactor to reduce JS/CSS payload size and improve accesibility:

* Removed semantic-ui assets
* Removed unused 'sphinx_tabs_nowarn' sphinx option
* JS/CSS assets are now copied across by sphinx when builing, rather than being copied by the extension
* Changed tab HTML to use tab roles
* Changed tab label colour, to increase contrast with background
* Added ARIA labels for tabs and panels
* Added tabindex atributes to allow users to focus and switch tabs using a keyboard
* Added a margin below images inside tab content

✨ New features:

* Selecting an open tab now closes the tabs panel
* The last selected group tab persists between pages (if the browser supports session storage)
Links

@stsewd
Copy link
Member

stsewd commented Feb 8, 2021

Tabs aren't working https://docs--7896.org.readthedocs.build/en/7896/config-file/v2.html maybe something to do with this change

JS/CSS assets are now copied across by sphinx when builing, rather than being copied by the extension

Something incompatible somewhere?

@stsewd
Copy link
Member

stsewd commented Feb 8, 2021

Can't replicate locally, and tabs in their docs work fine :/ https://sphinx-tabs.readthedocs.io/en/latest/

@stsewd
Copy link
Member

stsewd commented Feb 8, 2021

It's like the click event doesn't get attached... but running the debugger that code gets executed. After attaching them again manually they work

const allTabs = document.querySelectorAll('.sphinx-tabs-tab');
allTabs.forEach(tab => {
    tab.addEventListener("click", changeTabs);
  });

So is like something is unregistering the events somewhere

@stsewd stsewd force-pushed the pyup/scheduled-update-2021-02-08 branch from ae68a7b to ee047f7 Compare February 9, 2021 00:08
@stsewd
Copy link
Member

stsewd commented Feb 9, 2021

Ok, looks like search is the incompatible one readthedocs/readthedocs-sphinx-search#82

@stsewd stsewd merged commit f18c584 into master Feb 9, 2021
@stsewd stsewd deleted the pyup/scheduled-update-2021-02-08 branch February 9, 2021 01:06
@@ -11,7 +11,7 @@ Sphinx==3.4.3
docutils==0.14 # pyup: ignore

sphinx_rtd_theme==0.5.1
sphinx-tabs==2.0.1
sphinx-tabs==1.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a # pyup: ignore and a comment explaining why we can't upgrade it yet linking to the issue in search extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants