New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain: allow to disable domain creation/update #8020
Conversation
@stsewd Can you explain a little more what's the use case for this? I'm not able to follow what's the intended UX here. |
Users in .com can skip the current validation (isn't any) to create a custom domain. This change doesn't allow creating or editing existent domains, but they can be deleted. |
Why do we want to restrict these? |
People that don't have a valid subscription |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
7908d46
to
c97c0b2
Compare
4c16b1f
to
46685cc
Compare
This to have better validation in .com. We still allow to delete them.
46685cc
to
a67f4c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a simple enough change.
This is a beta feature, it can be enabled by <a href="mailto:{{ SUPPORT_EMAIL }}">asking support</a>. | ||
{% url 'support' as support_url %} | ||
{% blocktrans trimmed with support_url=support_url %} | ||
This is a beta feature, it can be enabled by <a href="{{ support_url }}">contacting support</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't beta features though, right? Seems we want to make this a bit more configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah not all, but last time this was a message shown when traffic analytics was in beta, we aren't using this message in .org AFAIK.
If we go with having some features available only for gold users, then we can change this to be more generic/configurable I guess
This is to have better validation in .com.
We still allow to delete them.
We override these templates in .com completely, so there are added in .com as well.
We are still showing the "Save" button, but it's disabled, don't think we have a style for "disabled" buttons.