Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain: allow to disable domain creation/update #8020

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 15, 2021

This is to have better validation in .com.
We still allow to delete them.

We override these templates in .com completely, so there are added in .com as well.
We are still showing the "Save" button, but it's disabled, don't think we have a style for "disabled" buttons.

@stsewd stsewd requested a review from a team March 16, 2021 19:14
@humitos
Copy link
Member

humitos commented Mar 29, 2021

@stsewd Can you explain a little more what's the use case for this? I'm not able to follow what's the intended UX here.

@stsewd
Copy link
Member Author

stsewd commented Mar 30, 2021

@stsewd Can you explain a little more what's the use case for this? I'm not able to follow what's the intended UX here.

Users in .com can skip the current validation (isn't any) to create a custom domain. This change doesn't allow creating or editing existent domains, but they can be deleted.

@humitos
Copy link
Member

humitos commented Mar 30, 2021

This change doesn't allow creating or editing existent domains, but they can be deleted.

Why do we want to restrict these?

@stsewd
Copy link
Member Author

stsewd commented Mar 30, 2021

Why do we want to restrict these?

People that don't have a valid subscription

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jun 2, 2021
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Jun 2, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jul 21, 2021
@stale stale bot closed this Jul 31, 2021
@stsewd stsewd reopened this Sep 23, 2021
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Sep 23, 2021
@stsewd stsewd requested a review from a team as a code owner October 20, 2021 18:14
@stsewd stsewd force-pushed the allow-disable-domain branch 2 times, most recently from 4c16b1f to 46685cc Compare October 20, 2021 18:35
This to have better validation in .com.
We still allow to delete them.
@stsewd stsewd removed the request for review from a team October 20, 2021 19:17
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple enough change.

This is a beta feature, it can be enabled by <a href="mailto:{{ SUPPORT_EMAIL }}">asking support</a>.
{% url 'support' as support_url %}
{% blocktrans trimmed with support_url=support_url %}
This is a beta feature, it can be enabled by <a href="{{ support_url }}">contacting support</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't beta features though, right? Seems we want to make this a bit more configurable.

Copy link
Member Author

@stsewd stsewd Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah not all, but last time this was a message shown when traffic analytics was in beta, we aren't using this message in .org AFAIK.

If we go with having some features available only for gold users, then we can change this to be more generic/configurable I guess

@stsewd stsewd merged commit 19efa34 into master Oct 20, 2021
@stsewd stsewd deleted the allow-disable-domain branch October 20, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants