Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: don't expand envvars in Gitpython #8263

Merged
merged 1 commit into from Jun 15, 2021
Merged

Git: don't expand envvars in Gitpython #8263

merged 1 commit into from Jun 15, 2021

Commits on Jun 14, 2021

  1. Git: don't expand envvars in Gitpython 

    - Gitpython expands envvars by default
  We execute gitpython outside the containers.
  Currently there isn't a way to exploit this vulnerability
  (looks like gitpython is aware of this and may change the default
  to false any time https://github.com/gitpython-developers/GitPython/blob/617c09e70bfd54af1c88b4d2c892b8d287747542/git/repo/base.py#L142-L143)
- In some places we were executing git commands outside the container
  (to get the commit), let's always use the current env (docker in
  production).
    @stsewd
    stsewd committed Jun 14, 2021
    Copy the full SHA
    aaeba69 View commit details
    Browse the repository at this point in the history