New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json schema #8294
feat: add json schema #8294
Conversation
8355a94
to
099ead0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over this!
I interpreted that as "take that same action as with pip file support". Just noting the dropped sections here for future reference.Pipfile (
|
yes, that was it |
Co-authored-by: Santos Gallegos <stsewd@protonmail.com>
I did the things you asked for
Can I also just confirm, did I reference the correct YAML Schema when I created the JSON Schema? 🤔 (I used this one.) Does the YAML Schema need to be updated separately as well? |
We do allow
Yeah, that scheme is the one, but it has some ideas that were never implemented, we may remove it and use this json scheme instead of yamale, so no need to update it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@SethFalco let us know if you need anything from us to submit this to https://github.com/SchemaStore/schemastore/ |
Thanks for that! I think it's simple, so no need to worry. {
"name": "Read the Docs",
"description": "Read the Docs configuration file",
"fileMatch": [
"readthedocs.yml",
"readthedocs.yaml",
".readthedocs.yml",
".readthedocs.yaml"
],
"url": "https://raw.githubusercontent.com/readthedocs/readthedocs.org/master/readthedocs/rtd_tests/fixtures/spec/v2/schema.json"
} |
Assuming I've understood the YAML Schema correctly (I did read the Yamale README), I believe they should be equivalent (or at least almost equivalent.)
I made a new PR instead of reviewing an older one, as I felt there was a lot to change.
I've tested this against the following:
Note: Before testing I manually changed all
python.version
values to3.6
as original values (3.7
/3.8
) aren't valid against the schema. (Maybe consider usingstring
rather thanenum
here?)Let me know if anything looks off to you!
Subtle Differences