Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call analytics tracking of flyout when analytics are enabled #8398

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Only call analytics tracking of flyout when analytics are enabled #8398

merged 1 commit into from
Aug 6, 2021

Conversation

ericholscher
Copy link
Member

Fixes #8341

@ericholscher
Copy link
Member Author

I tested this locally with a reproduced docs build, and it works 👍

@ericholscher
Copy link
Member Author

This will go out next Tuesday. 👍

@ericholscher ericholscher merged commit d4fe8ce into master Aug 6, 2021
@ericholscher ericholscher deleted the fix-analytics-gtag branch August 6, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

safari doesn't allow the flyout menu. mobile + desktop
3 participants
@ericholscher @davidfischer @stsewd