Track organization artifacts cleanup #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extra field on the `Organization` model to keep track if its artificats were already cleanup. This allows us to filter disabled organization and run the cleaning periodically. The new field `Organization.artifacts_cleaned` is automatically set as `False` when a new build happens for any Project under the organization and is set to `True` when running a Django Admin action over the organization.
humitos
force-pushed
the
humitos/assets-cleanup
branch
from
660cc53
to
46d63ef
Compare
|
If this is only taking into consideration if the organization has built versions, I think this can be a property instead, we already track if a version is built in the model readthedocs.org/readthedocs/builds/models.py Line 150 in 92f6224 |
|
@stsewd I don't understand this comment. We are trying to solve a billing issue, not anything with the builders or Version state. Basically this PR: https://github.com/readthedocs/readthedocs-ops/pull/982/files |
ericholscher
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra field on the
Organizationmodel to keep track if its artifactswere already cleanup. This allows us to filter disabled organizations and run the
cleaning periodically.
The new field
Organization.artifacts_cleanedis automatically set asFalsewhen a new build happens for any Project under the organization and is set to
Truewhen running a Django Admin action over the organization.