Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note about how to use Anaconda Project. #8436

Merged
merged 1 commit into from Aug 31, 2021

Conversation

mforbes
Copy link
Contributor

@mforbes mforbes commented Aug 22, 2021

With a small modification -- using dependencies: as an alias for packages: -- one can also use Anaconda Project anaconda-project.yaml files in place of environment.yml files.

Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mforbes for your contribution! I left a couple of comments. It would also be nice if you could squash the commits into one.

Are you already using this successfully in some project on Read the Docs?

docs/config-file/v2.rst Outdated Show resolved Hide resolved
docs/config-file/v2.rst Outdated Show resolved Hide resolved
docs/guides/conda.rst Outdated Show resolved Hide resolved
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good tip to me. However, is it relevant to document the same content in two places? Wouldn't be better to add this into a FAQ instead?

@mforbes
Copy link
Contributor Author

mforbes commented Aug 24, 2021

@humitos I think that the FAQ would be a better place: as long as it is searchable. I will try this, and then collapse the changes.

@mforbes mforbes force-pushed the patch-1 branch 2 times, most recently from b06acc0 to e27f730 Compare August 24, 2021 13:52
@mforbes
Copy link
Contributor Author

mforbes commented Aug 24, 2021

Okay: I have squashed the commits, put the comment in the FAQ, and included an example where I am using this.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left some comments and I will ping @astrojuanlu for the final review.

docs/faq.rst Outdated Show resolved Hide resolved
docs/faq.rst Outdated Show resolved Hide resolved
docs/faq.rst Outdated Show resolved Hide resolved
docs/faq.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astrojuanlu astrojuanlu merged commit 3491329 into readthedocs:master Aug 31, 2021
@astrojuanlu
Copy link
Contributor

Thanks a lot @mforbes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants