Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote and restructure guides #8528

Merged
merged 11 commits into from
Sep 28, 2021
Merged

Promote and restructure guides #8528

merged 11 commits into from
Sep 28, 2021

Conversation

astrojuanlu
Copy link
Contributor

See discussion at #8321. After extensive discussion, I approached this with several goals in mind:

  • Reordering the guides in a more meaningful way,
  • removing the sphinx/community/commercial separation,
  • studying what guides should be feature content, and
  • trying to minimize the changes to the index page.

And, in addition, I had some non-goals:

I ended up doing these four things:

  1. Move some guides that were clearly "feature documentation" to the "getting started" section.
  2. Replace the Tools/Community/Commercial categories by Authors/Administrators/Developers.
  3. Reorder the guides according to (present) popularity.
  4. Present guides in the index in a similar fashion as we do with the rest of our documentation.

I think these categories make it more explicit what is the audience of each document, although there are some grey areas of course.

Also, for the index, I picked the most popular guides, and for the rest, I added an "others" link to not overwhelm (more) the readers.

@astrojuanlu astrojuanlu requested a review from a team September 27, 2021 14:30
@astrojuanlu
Copy link
Contributor Author

astrojuanlu commented Sep 27, 2021

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 💯 refactor. I love this structure of the guides -- much more intuitive and valuable.

I would like to perhaps use this as an opportunity to clean up some of the titles on the pages, if possible. I see you already did a couple, but I think there's a lot more room here to clarify them (and make them better for SEO).

I'd also love to figure out a core set of features that we care about, and promote/document effectively. I feel like we're slowly getting to that point, but we should really discuss and have it defined somewhere (and very obviously highlighted on the website/marketing pages/docs).

A couple questions for moving forward:

  • How do we distinguish .com content? Perhaps an emoji and a warning at the top of the guide or similar to what we do for sphinx-only content?
  • I feel like the First steps & Getting started sections are a bit muddled (especially since the first steps contain getting started docs). I think we can work to clean this up a bit. Perhaps rename Getting started section to Platform Overview or Feature Documentation or Primary Features? We already have Advanced Features, so maybe it makes sense to differentiate it from that?

docs/analytics.rst Show resolved Hide resolved
docs/guides/administrators.rst Outdated Show resolved Hide resolved
@@ -0,0 +1,18 @@
Guides for documentation authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better way to think about the guide structure 💯

docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
* :doc:`/guides/tools`
* :doc:`/guides/platform`
* :doc:`/guides/commercial`
* **For documentation authors**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows we need more of these guides 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double yes: we need more guides, and some of the current ones should probably be moved to Sphinx...

docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
astrojuanlu and others added 2 commits September 28, 2021 10:55
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@astrojuanlu
Copy link
Contributor Author

Thanks for the thorough feedback @ericholscher . On your questions:

How do we distinguish .com content? Perhaps an emoji and a warning at the top of the guide or similar to what we do for sphinx-only content?

I was precisely thinking of an emoji. And rather than a warning, a custom-colored admonition?

I feel like the First steps & Getting started sections are a bit muddled (especially since the first steps contain getting started docs). I think we can work to clean this up a bit. Perhaps rename Getting started section to Platform Overview or Feature Documentation or Primary Features? We already have Advanced Features, so maybe it makes sense to differentiate it from that?

Totally agree. Will review this now.

@astrojuanlu
Copy link
Contributor Author

Opened #8535 about the first part. Hope to tackle that in a future iteration.

@astrojuanlu astrojuanlu force-pushed the promote-restructure-guides branch 2 times, most recently from 15c3075 to e3a8ed5 Compare September 28, 2021 16:06
@astrojuanlu
Copy link
Contributor Author

I'm done with the first round of review - @ericholscher I see that you approved, but I have made some significant changes since, so I'm asking for another review just in case.

@astrojuanlu astrojuanlu requested a review from a team September 28, 2021 16:15
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- really excited for the docs to keep improving 💯

@@ -1,7 +1,7 @@
Analytics
---------
Traffic Analytics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Matching the UI is a good place to start. I could see moving to something like:

Suggested change
Traffic Analytics
Traffic Analytics - See top performing doc pages

In the future, but we'd need to change up how we're linking to them. Perhaps adding a subhead of some kind would be another way to handle this.

docs/custom_domains.rst Show resolved Hide resolved
docs/custom_domains.rst Show resolved Hide resolved
docs/guides/advanced-search.rst Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
@astrojuanlu astrojuanlu merged commit c36aaf8 into master Sep 28, 2021
@astrojuanlu astrojuanlu deleted the promote-restructure-guides branch September 28, 2021 16:34
@astrojuanlu astrojuanlu mentioned this pull request Sep 28, 2021
@astrojuanlu
Copy link
Contributor Author

Thanks a lot! Opened #8537 to focus on SEO.

@humitos
Copy link
Member

humitos commented Sep 29, 2021

I'm late on this PR, but I'd like to suggest getting rid of | as separator of the links because it's almost impossible to read them, IMO. Also, it makes super hard to start reading the first word, realize that it's not the guide you are looking for and jump to the next link because there is almost no visual difference between where a link ends and a new one starts.

Now that we have just a few links in this section, can't we just use bullets for them:
Screenshot_2021-09-29_13-18-08

@astrojuanlu
Copy link
Contributor Author

I agree that the vertical separators are not very nice, and I think we have discussed about removing them.

However, a stated non-goal of this PR was to not "Evolve the visual aspect of our documentation", so I kept consistency to what we have now to avoid derailing the discussion. @nienn proposed some cool ideas in #8513, but I think we first need to think through the structure of all our docs. As @ericholscher said above,

I'd also love to figure out a core set of features that we care about, and promote/document effectively. I feel like we're slowly getting to that point, but we should really discuss and have it defined somewhere (and very obviously highlighted on the website/marketing pages/docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants