Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expierment with pip-tools for our docs.txt requirements #9124

Merged
merged 6 commits into from May 3, 2022

Conversation

ericholscher
Copy link
Member

This will then generate a full set of transitive dependencies,
so that our builds shouldn't break.

This will then generate a full set of transitive dependencies,
so that our builds shouldn't break.
@ericholscher ericholscher requested a review from a team as a code owner April 19, 2022 16:03
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! The next step is to do the same for our own app dependencies, maybe? 😄

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to testing pip-tools more, it's a really low friction version of a Python package lock file and so should be easy to introduce to projects.

@ericholscher
Copy link
Member Author

Yea, it was pretty darn straightforward here! Definitely something we should be recommending more. There's also a hash mode that adds some more security: https://pip-tools.readthedocs.io/en/latest/#using-hashes

@ericholscher ericholscher merged commit 01466de into main May 3, 2022
@ericholscher ericholscher deleted the pip-compile-docs-requirements branch May 3, 2022 21:42
@humitos
Copy link
Member

humitos commented May 30, 2022

I introduced pip-tools + dependabot on readthedocs/sphinx-hoverxref#182. We can use it as example to do to the same here and remove pyup that does not support pip-tools (I asked them via support).

The next feature is to open a PR for the dependencies that were released one week ago at least 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants