Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mamba: remove CONDA_USES_MAMBA feature flag #9153

Merged
merged 1 commit into from May 2, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 28, 2022

Mamba can be used via build.tools.python: mambaforge now.

This PR removes the CONDA_USES_MAMBA feature flag since we already contact
most of the users and opened a PR on their repositories with the config file
required for this change and we also sent an in-site notification to all those
projects still using it.

The message said this feature flag will be removed on May 1st. So, we are all
good to merge and deploy next week (May 3rd).

Mamba can be used via `build.tools.python: mambaforge` now.

This PR removes the `CONDA_USES_MAMBA` feature flag since we already contact
most of the users and opened a PR on their repositories with the config file
required for this change and we also sent an in-site notification to all those
projects still using it.

The message said this feature flag will be removed on May 1st. So, we are all
good to merge and deploy next week (May 3rd).
@humitos humitos requested a review from a team as a code owner April 28, 2022 15:11
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I do wish there was a better way to note this removal, but I guess the CHANGELOG is good enough?

@humitos
Copy link
Member Author

humitos commented May 2, 2022

Hrm, yeah. I don't think we have a better way than that, unfortunately.

@humitos humitos merged commit 26e3b2f into main May 2, 2022
@humitos humitos deleted the humitos/remove-mamba-feature-flag branch May 2, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants