Local development: use nodemon to watch files instead of watchmedo
#9338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been dealing with a problem with `watchmedo` that restart the process when it shouldn't be restarted and it doesn't restart it when it should. I got tired debugging `watchmedo` and I was suggested to give it a try to `nodemon` because we are already using it in other projects. I'm not super happy adding a node dependency to the Dockerfile, but I didn't find a better way to do it. I did some tests with the configuration proposed and it seemed to work pretty well. I'm sure we will find some edge cases, but we always can tune it a little more later. Closes #8802
agjohnson
approved these changes
Jun 15, 2022
It's not required anymore since we are using `nodemon` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been dealing with a problem with
watchmedothat restart the processwhen it shouldn't be restarted and it doesn't restart it when it should.
I got tired debugging
watchmedoand I was suggested to give it a try tonodemonbecause we are already using it in other projects. I'm not super happyadding a node dependency to the Dockerfile, but I didn't find a better way to do it.
I did some tests with the configuration proposed and it seemed to work pretty
well. I'm sure we will find some edge cases, but we always can tune it a little
more later.
Requires: readthedocs/common#150
Closes #8802