Sphinx domain: change type of ID field #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using the default autofield: - https://docs.djangoproject.com/en/4.1/ref/settings/#std-setting-DEFAULT_AUTO_FIELD - https://docs.djangoproject.com/en/4.1/ref/models/fields/#django.db.models.AutoField Which uses the IntegerField, which has a limit of 2**31 - 1, looks like our SphinxDomain models have passed that limit.
stsewd
force-pushed
the
change-type-id-field
branch
from
575ebfe
to
62690af
Compare
agjohnson
approved these changes
Aug 8, 2022
Merged
|
I'm not sure what to do with this PR for today's deploy. However, I will merge it since we can decide whether or not run the migration while doing the deploy, anyways. So, I prefer to have the image built with all the content and decide what to do with more context at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the default autofield:
Which uses the IntegerField, which has a limit of 2**31 - 1,
looks like our SphinxDomain models have passed that limit.
馃摎 Documentation preview 馃摎: https://docs--9482.org.readthedocs.build/en/9482/