Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Make VersionInline Read-only #9697

Merged
merged 1 commit into from Nov 17, 2022

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Oct 26, 2022

closes #9687


馃摎 Documentation previews 馃摎

@saadmk11 saadmk11 requested a review from a team as a code owner October 26, 2022 13:10
@saadmk11 saadmk11 requested a review from stsewd October 26, 2022 13:10
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix removes all the input fields that were causing out-of-bounds form submissions and requiring DATA_UPLOAD_MAX_NUMBER_FIELDS

It also makes the admin easier to read. Every row has a shortcut link to the Version's own admin page.

image

LGTM 馃憤 Thanks for fixing this @saadmk11 馃憤

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Waaaay better! Thanks 鉂わ笍

@humitos humitos merged commit f7ea3bd into readthedocs:main Nov 17, 2022
@saadmk11 saadmk11 deleted the readonly-inline branch November 17, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: bad request saving project admin
3 participants