Skip to content

Commit

Permalink
Do not bump the version in auto-maintained file package-lock.json
Browse files Browse the repository at this point in the history
  • Loading branch information
benjaoming committed Aug 19, 2022
1 parent 17d51de commit 5087916
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 4 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,10 @@ To release a new version of the theme, core team will take the following steps:
#. Update the changelog (``docs/changelog.rst``) with the version information.
#. Run ``python setup.py update_translations`` to compile new translation files
and update Transifex.
#. Run ``python setup.py build_assets`` to rebuild all the theme assets and the Python
package.
#. Run ``npm run build`` to rebuild all the theme assets and the Python
package, notice that ``package-lock.json`` will be updated with a new package
version. But take care that it isn't also bumping versions of dependencies
in ways that are risky to the release.
#. Commit these changes.
#. Tag the release in git: ``git tag $NEW_VERSION``.
#. Push the tag to GitHub: ``git push --tags origin``.
Expand Down
4 changes: 0 additions & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ first_value = 1
search = "version": "{current_version}",
replace = "version": "{new_version}",

[bumpversion:file:package-lock.json]
search = "version": "{current_version}",
replace = "version": "{new_version}",

[bumpversion:file:docs/changelog.rst]
search = .. |development_version| replace:: {current_version}
replace = .. |development_version| replace:: {new_version}

0 comments on commit 5087916

Please sign in to comment.