Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flexible layout for hlist directives #1108

Open
Blendify opened this issue Apr 1, 2021 · 1 comment · May be fixed by #1109
Open

Use flexible layout for hlist directives #1108

Blendify opened this issue Apr 1, 2021 · 1 comment · May be fixed by #1109
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related Good First Issue Good for new contributors Needed: patch A pull request is required

Comments

@Blendify
Copy link
Member

Blendify commented Apr 1, 2021

Problem

The current hlist can look bad on mobile or when using many columns.

Reproducible Project

https://docs.blender.org/api/current/bpy.types.AlphaUnderSequence.html

Error Logs/Results

image

As you can see the list items extend beyond viewport when the viewport is narrow.

Expected Results

The columns should break into new rows.

Environment Info

  • Python Version: 3.9.x
  • Sphinx Version: 3.5.1
  • RTD Theme Version: 0.5.1
@Blendify Blendify added Bug A bug Needed: replication Bug replication is required labels Apr 1, 2021
@Blendify
Copy link
Member Author

Blendify commented Apr 1, 2021

This is relatively easy to fix using display: flex and flex-flow: row wrap

@Blendify Blendify added Accepted Accepted issue on our roadmap Design Design or UX/UI related Good First Issue Good for new contributors Needed: patch A pull request is required and removed Needed: replication Bug replication is required labels Apr 1, 2021
Blendify added a commit that referenced this issue Apr 2, 2021
@Blendify
hlist: Make columns collapse when viewport is narrow
44ec5fa 
When the items of the hlist cannot fit into the viewport a collumn is split into a new row until the content fits.

This dramically improves mobile experience, for example https://docs.blender.org/api/current/bpy.types.AlphaUnderSequence.html will introduce horizonal scrolling on the whole viewport which causes visual glitchs with other content.

Fixes #1108
@Blendify Blendify linked a pull request Apr 2, 2021 that will close this issue
Open
Blendify added a commit that referenced this issue Apr 19, 2021
@Blendify
Squashed commit of the following:
5f4f830 
commit 4d14428
Merge: 69f0472 ca2719b
Author: Aaron Carlisle <carlisle.b3d@gmail.com>
Date:   Mon Apr 5 17:21:27 2021 -0400

    Merge branch 'master' into Blendify/fix-1108

commit 69f0472
Author: Aaron Carlisle <carlisle.b3d@gmail.com>
Date:   Mon Apr 5 17:20:09 2021 -0400

    Update Assets

commit 26ac01c
Author: Aaron Carlisle <carlisle.b3d@gmail.com>
Date:   Mon Apr 5 13:19:41 2021 -0400

    Add Ie suppport

commit 44ec5fa
Author: Aaron Carlisle <carlisle.b3d@gmail.com>
Date:   Thu Apr 1 22:27:57 2021 -0400

    hlist: Make columns collapse when viewport is narrow

    When the items of the hlist cannot fit into the viewport a collumn is split into a new row until the content fits.

    This dramically improves mobile experience, for example https://docs.blender.org/api/current/bpy.types.AlphaUnderSequence.html will introduce horizonal scrolling on the whole viewport which causes visual glitchs with other content.

    Fixes #1108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related Good First Issue Good for new contributors Needed: patch A pull request is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hlist: Make columns collapse when viewport is narrow readthedocs/sphinx_rtd_theme
1 participant
@Blendify