Extra padding in "literalinclude" directive

[argaen]

Details

• Project URL: http://aiocache.readthedocs.io/en/latest/
• Build URL (if applicable): https://readthedocs.org/projects/aiocache/builds/5324336/ (happens in any build)
• Read the Docs username (if applicable): argaen

Expected Result

the code snippets should appear without the extra bottom padding. Only happens when using the literalinclude directive. For example in the two big code snippets in http://aiocache.readthedocs.io/en/latest/configuration.html.

Actual Result

Extra padding added coming I don't know from where:

[klas-genestack]

It was fine at least in v0.1.9 (I've just updated from it).

[klas-genestack]

I've bisected this issue:

f22bfd278ef369e7de7ac7789b59622c1ddd53ab is the first bad commit
commit f22bfd278ef369e7de7ac7789b59622c1ddd53ab
Author: Denis Volpato Martins <denis@ostec.com.br>
Date:   Mon Dec 5 12:35:53 2016 -0200

    Add 'Edit on GitLab' support

:100644 100644 1c15151d6d896298dbfa1c6bf998be8db31f4d51 ac708862f724da85c83667452d2c008b86db1be7 M	bower.json
:040000 040000 bd056e6f5ebb7726aad75c8fae6f4b5e3c340445 6251f5c40614b878b9c929cb01e3a2765186d44e M	sass
:040000 040000 227bee87670b068757a893aff7a932c4b125544e aa2dcba71a3f70e256e15c2527611dd7f4ce4825 M	sphinx_rtd_theme

@denisvm, can I interest you in this? =)

[Blendify]

Are you sure? That commit does nothing that might affect this.

[denisvm]

@Blendify, actually @klas-genestack may be right. My changes didn't cause this issue, but when I ran grunt, it updated the minified CSS files, inheriting all the older modifications that were made only in the source SASS files.

With that I've inherited the change made in #344 (Fix spacing in pre) with 7f307a8. If you disable this change, it'll fix this specific issue.

This is related to #381.

[klas-genestack]

@Blendify, I'm pretty sure it does (you can test yourself: I can provide you all the data, if you're interested), and I think @denisvm interprets it correctly.

[szabolcsdombi]

I get the same problem.

• The .rst file
• The result
• The included file

[szabolcsdombi]

Those are not extra lines:

In my case the file has 51 lines and the line numbers have different height values so those are shifted.

I just changed the class on the code:

and now I get

previously it was

[szabolcsdombi]

The problem is in the theme.css

.rst-content .highlight>pre {
    line-height: normal; /* this should be removed */
}

[szabolcsdombi]

A quick hack to solve the issue:

Add this to a static css then load it from the conf.py

.rst-content .highlight>pre {
    line-height: 18px;
}

[TonyFlury]

Sorry if this is the wrong place to add this comment, but any idea when this will get fixed ? I use the rtd theme a lot and a quick fix would be useful.

[Blendify]

#504 Should fix this can people try using it?

[Blendify]

Im closing this issue if people still have an issue after using latest master then we can re-open

[TonyFlury]

Can someone state when this latest master will be deployed on pypi ? I don’t want my documentation to be based on non released builds of the ‘latest master’

[szabolcsdombi]

Using the sphinx_rtd_theme from PyPI:

the bug is still present

---

Using the sphinx_rtd_theme from github:

the bug is fixed

python -m pip install https://github.com/rtfd/sphinx_rtd_theme/archive/master.zip -U

Version info:

>>> import sphinx_rtd_theme
>>> sphinx_rtd_theme.__version__
'0.2.5b2'

[TonyFlury]

Exactly - using the 'latest GIT master' is not a viable solution to be frank.  -- Anthony Flury anthony.flury@btinternet.com From: Szabolcs Dombi <notifications@github.com> To: rtfd/sphinx_rtd_theme <sphinx_rtd_theme@noreply.github.com> Cc: Tony Flury <anthony.flury@btinternet.com>; Comment <comment@noreply.github.com> Sent: Monday, January 15, 2018 7:54 AM Subject: Re: [rtfd/sphinx_rtd_theme] Extra padding in "literalinclude" directive (#417) Using the sphinx_rtd_theme from PyPI:the bug is still presentUsing the sphinx_rtd_theme from github:the bug is fixedpython -m pip install https://github.com/rtfd/sphinx_rtd_theme/archive/master.zip -U Version info:>>> import sphinx_rtd_theme

>> sphinx_rtd_theme.__version__

'0.2.5b2'— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Blendify]

@ericholscher @agjohnson Can we please take the steps to release 0.2.5!