Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Tutorial restructuring #174

Merged
merged 17 commits into from
Jan 23, 2018
Merged

Tutorial restructuring #174

merged 17 commits into from
Jan 23, 2018

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Jan 15, 2018

Proposed changes:

  • restructuring of the tutorials

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@ricwo ricwo changed the title Tutorial Tutorial restructuring Jan 15, 2018
@ricwo ricwo requested a review from amn41 January 15, 2018 13:59
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ricwo ! I made a few more tweaks. I wanted to motivate the users a bit by showing an example right at the top, rather than burying the running bot at the end of the tutorial.

@amn41
Copy link
Contributor

amn41 commented Jan 23, 2018

@tmbo @ricwo I removed line numbers in f1a8d36 because this causes a bunch of blank lines to be rendered. Supposedly fixed in latest rtd-theme but when I merged with our fork it didn't resolve the issue for me.

@tmbo
Copy link
Member

tmbo commented Jan 23, 2018

Which empty lines do you mean? I can't see any at http://core.rasa.ai/tutorial_basics.html and I am not sure why that should have changed with this PR

@amn41
Copy link
Contributor

amn41 commented Jan 23, 2018

@tmbo
Copy link
Member

tmbo commented Jan 23, 2018

ok we had that before - this is not an issue of empty lines, the lines are just not aligned to the line numbers

@amn41
Copy link
Contributor

amn41 commented Jan 23, 2018

what's the fix? shall I revert that commit then?

@tmbo
Copy link
Member

tmbo commented Jan 23, 2018

Give me a sec, looking into it right now

@tmbo
Copy link
Member

tmbo commented Jan 23, 2018

Ok @amn41 the fix got lost right here:

28e5842#diff-5bef800b7655c038d4f6f2a972d7b354L1

not sure why though. Can you add these line to docs/_static/custom.css again (file got deleted in that commit put is present in master, just without these lines...)

@tmbo tmbo merged commit fd4858a into master Jan 23, 2018
@tmbo tmbo deleted the tutorial branch January 23, 2018 16:15
@amn41 amn41 restored the tutorial branch January 24, 2018 05:29
@tmbo tmbo deleted the tutorial branch February 2, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants