Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen flashes on load #724

Closed
tvst opened this issue Feb 19, 2019 · 2 comments · Fixed by #848
Closed

Screen flashes on load #724

tvst opened this issue Feb 19, 2019 · 2 comments · Fixed by #848
Labels
Bug A bug

Comments

@tvst
Copy link

tvst commented Feb 19, 2019

Problem

When I go to any page using the RTD theme, my browser noticeably flashes white for a few dozen milliseconds before the page shows up. When I comment out modernizr.min.js from my HTML pages, the white flashes go away.

Reproducible Project

I see this in every project that uses the RTD theme. Which means I can repro it here too: https://sphinx-rtd-theme.readthedocs.io/en/stable

Steps to repro:

  1. Go to https://sphinx-rtd-theme.readthedocs.io/en/stable
    (This already repros the bug, but it's not so easy to notice on first load. So let's go to step 2)

  2. Click on "Configuration" on the left sidebar.
    Expected: the Configuration page seamlessly loads
    Actual: the screen flashes white and then the Configuration page loads

  3. You can repro this 100% of the time by clicking on top level links on the sidebar.

Error Logs/Results

There are no errors on the console.

Environment Info

  • Python Version: n/a
  • Sphinx Version: 1.8.4
  • RTD Theme Version: 0.4.3
  • Browser: Chrome Version 72.0.3626.96 (Official Build) (64-bit)
@jessetan
Copy link
Contributor

Modernizr causes 4 reflows on my test setup, possibility of removing it should get some renewed attention (#624)

@jessetan jessetan added the Bug A bug label Feb 20, 2019
@Blendify
Copy link
Member

+1 for removal.

nashif pushed a commit to zephyrproject-rtos/zephyr that referenced this issue Aug 28, 2019
modernizr.min.js is causing unnecessary reloads of a page causing
flashing of the browser window during page load (most noticiable with
firefox).  This empty script effectively wipes out the modernizr.min.js
unnecessarily loaded by the Sphinx rtd theme (see
readthedocs/sphinx_rtd_theme#724)

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
LeiW000 pushed a commit to LeiW000/zephyr that referenced this issue Sep 2, 2019
modernizr.min.js is causing unnecessary reloads of a page causing
flashing of the browser window during page load (most noticiable with
firefox).  This empty script effectively wipes out the modernizr.min.js
unnecessarily loaded by the Sphinx rtd theme (see
readthedocs/sphinx_rtd_theme#724)

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
3 participants