Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve page loading performance #7

Closed
grahamlopez opened this issue Sep 5, 2019 · 4 comments
Closed

improve page loading performance #7

grahamlopez opened this issue Sep 5, 2019 · 4 comments

Comments

@grahamlopez
Copy link
Contributor

in some browsers, there is a flash or brief pause before the css/js gets loaded. Other sites using sphinx with the same theme do not seem to do this (at least as badly). This might be due to several issues, and probably needs some investigation. See e.g. https://stackoverflow.com/a/12358419

@grahamlopez
Copy link
Contributor Author

is this something that @admgc and/or @pshires could help me out with?

@mpbelhorn
Copy link
Contributor

Maybe related to readthedocs/sphinx_rtd_theme#724

@mpbelhorn
Copy link
Contributor

Yes, this appears to be fixed in RTD theme version 0.4.3.dev0 at (at least) sphinx_rtd_theme commit feb0beb running on my local machine:

$ pipenv graph 
sphinx-rtd-theme==0.4.3.dev0
  - sphinx [required: Any, installed: 2.2.0]
    - alabaster [required: >=0.7,<0.8, installed: 0.7.12]
    - babel [required: >=1.3,!=2.0, installed: 2.7.0]
      - pytz [required: >=2015.7, installed: 2019.2]
    - docutils [required: >=0.12, installed: 0.15.2]
    - imagesize [required: Any, installed: 1.1.0]
    - Jinja2 [required: >=2.3, installed: 2.10.1]
      - MarkupSafe [required: >=0.23, installed: 1.1.1]
    - packaging [required: Any, installed: 19.2]
      - pyparsing [required: >=2.0.2, installed: 2.4.2]
      - six [required: Any, installed: 1.12.0]
    - Pygments [required: >=2.0, installed: 2.4.2]
    - requests [required: >=2.5.0, installed: 2.22.0]
      - certifi [required: >=2017.4.17, installed: 2019.9.11]
      - chardet [required: >=3.0.2,<3.1.0, installed: 3.0.4]
      - idna [required: >=2.5,<2.9, installed: 2.8]
      - urllib3 [required: >=1.21.1,<1.26,!=1.25.1,!=1.25.0, installed: 1.25.6]
    - setuptools [required: Any, installed: 41.2.0]
    - snowballstemmer [required: >=1.1, installed: 1.9.1]
    - sphinxcontrib-applehelp [required: Any, installed: 1.0.1]
    - sphinxcontrib-devhelp [required: Any, installed: 1.0.1]
    - sphinxcontrib-htmlhelp [required: Any, installed: 1.0.2]
    - sphinxcontrib-jsmath [required: Any, installed: 1.0.1]
    - sphinxcontrib-qthelp [required: Any, installed: 1.0.2]
    - sphinxcontrib-serializinghtml [required: Any, installed: 1.1.3]

@jack-morrison
Copy link
Contributor

jack-morrison commented Mar 10, 2020

A fix for this was introduced in 12458e0, and is in tagged version 0.4.3. I rebuilt the production docs yesterday and it has picked up the latest of 0.4.3; should include this change.

[tag:0.4.3] $ git branch --contains 12458e0a6a2264df37ee6ae021e312f40cea36f9
  master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants