Skip to content

Commit

Permalink
system-benchmarks: Enable post-lookup support
Browse files Browse the repository at this point in the history
Previously, our system benchmarks were running against Readyset with
post-lookup disabled. This meant that any of our benchmarks that
included queries that required post-lookup were actually proxying the
workload upstream. This led to a large discrepancy in benchmark results
between Postgres and MySQL due to Postgres handling certain aggregations
more efficiently than MySQL.

This commit fixes the issue by ensuring that our system benchmarks are
running against a Readyset instance with post-lookups enabled.

Change-Id: Id5c964c8f332e2a52e3811848927b4b61f62ef11
  • Loading branch information
ethowitz committed Apr 22, 2024
1 parent 74328c0 commit 0239854
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions system-benchmarks/benches/workload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,7 @@ fn start_adapter(upstream_url: &str) -> anyhow::Result<()> {
"standalone",
"--allow-unauthenticated-connections",
"--allow-full-materialization",
"--enable-experimental-post-lookup",
"--upstream-db-url",
upstream_url,
"--durability",
Expand Down

0 comments on commit 0239854

Please sign in to comment.