Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up use of options in JS #156

Open
IwanVosloo opened this issue Oct 25, 2018 · 0 comments
Open

Clean up use of options in JS #156

IwanVosloo opened this issue Oct 25, 2018 · 0 comments

Comments

@IwanVosloo
Copy link
Member

We sometimes have put all the attributes of a JS widget (aka jqueryui widget) on its this.options. I find this confusing and cannot think of a good reason for doing this.

We have moved such attributes in reahl.hashchange.js that did not belong with options to be on this.

What needs to be done still, is to go through all such javascript Widgets and check if any others are still doing this....and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant