sessionKey null check for command line #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Framer.java - Line 158
sessionsEncoder.next() .....
.localCompId(sessionKey.localCompId()
NullPointerException - sessionKey is Null
Steps to reproduce:
Cause:
When a new client attempts to connect to Artio server, new instance of FixGatewaySession is created with sessionKey = null
The sessionKey is populated on Logon (FixGatewaySession.onLogon)
But in a scenario where there is sequence mismatch, the FixGatewaySession instance is created but onLogon callback is not invoked. Therefore sessionKey remains uninitialised
Solution:
Null check is added for sessionKey. The command printAllSessions works as expected after this change.
Many Thanks!
cc: @wojciech-adaptive