Fix lower_acl_than_parent rule rewriter by preserving leading white…

…space (#4861)
realm · Apr 3, 2023 · bd444fc · bd444fc
1 parent ee849bc
commit bd444fc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,7 +25,9 @@
 
 #### Bug Fixes
 
-* None.
+* Fix `lower_acl_than_parent` rule rewriter by preserving leading whitespace.  
+  [SimplyDanny](https://github.com/SimplyDanny)
+  [#4860](https://github.com/realm/SwiftLint/issues/4860)
 
 ## 0.51.0: bzllint
 

diff --git a/Source/SwiftLintFramework/Rules/Lint/LowerACLThanParentRule.swift b/Source/SwiftLintFramework/Rules/Lint/LowerACLThanParentRule.swift
@@ -68,7 +68,17 @@ struct LowerACLThanParentRule: OptInRule, ConfigurationProviderRule, SwiftSyntax
             Example("class Foo { ↓public func bar() {} }"):
                 Example("class Foo { func bar() {} }"),
             Example("actor Foo { ↓public func bar() {} }"):
-                Example("actor Foo { func bar() {} }")
+                Example("actor Foo { func bar() {} }"),
+            Example("""
+                struct Foo {
+                    ↓public func bar() {}
+                }
+                """):
+                Example("""
+                struct Foo {
+                    func bar() {}
+                }
+                """)
         ]
     )
 
@@ -120,7 +130,10 @@ private extension LowerACLThanParentRule {
                     trailingTrivia: .space
                 )
             } else {
-                newNode = DeclModifierSyntax(name: .keyword(.internal, presence: .missing))
+                newNode = DeclModifierSyntax(
+                    leadingTrivia: node.leadingTrivia ?? .zero,
+                    name: .identifier("")
+                )
             }
 
             return super.visit(newNode)